See this page as a slide show

Pet Peeves

CS253 Pet Peeves

void main()

• In ANSI C++, main returns an int. Period.
• Some compilers accept void main as a non-standard extension.
• However, int main is standard, so it works everywhere.
• It’s shorter, too.

ASCII constants

There is no benefit to memorizing the ASCII table, at the cost of program readability.

Sure, this works:

    if (c == 65)

But so does this:

    if (c == 'A')

• Which is easier to understand & modify?
• Besides, who says that all computers use ASCII?
  • Some use EBCDIC.

Doing work for the computer

Doing work for the computer is like cleaning up for the maid. I see code like this:

    inches = miles * 63360;  // 63,360 inches in a mile

When I ask the student, “How’d you come up with that number?”, I often hear “I multiplied 5280 by 12 on a calculator.” Gosh—that sounds like something that the computer should be doing:

    inches = miles * 5280 * 12; // 5280 feet/mile, 12 inches/foot

The compiler will fold the constant multiplication for you.

Indentation

Indentation is often regarded as useless. As long as the program works, that’s all that matters!

Those of us who have to read and maintain your code disagree.

Casting

Casting is not magic.

char buf[] = "123";
long n = (long) buf;
cout << n << '\n';

140731558756660

  If you use casting, then something is wrong. Think again.

vector/string methods

vector<int> v = {11,22,33};
cout << v.at(0) + v.at(2) << '\n';
cout << v[0] + v[2] << '\n';

44
44

  Similarly, for strings:

string s = "Jack Applin";
cout << "My initials are " << s[0] << s[5] << '\n';

My initials are JA

Not everything is a reference

You do not have to use new to create an object:

string s;
s.push_back('C');
s.push_back('S');
s.push_back('U');
cout << s << '\n';

CSU

eof() does not predict

eof() does not mean “Will the next read fail?”.

ifstream in("/etc/resolv.conf");
while (!in.eof()) {
    string s;
    getline(in, s);
    cout << "** " << s << '\n';
}

** search cs.colostate edu colostate.edu
** nameserver 129.82.45.181
** nameserver 129.82.103.78
** nameserver 129.82.103.79
** 

  eof() means “Did the previous read fail?”.

ifstream in("/etc/resolv.conf");
string s;
while (getline(in, s))
    cout << "** " << s << '\n';

** search cs.colostate edu colostate.edu
** nameserver 129.82.45.181
** nameserver 129.82.103.78
** nameserver 129.82.103.79

Boolean is hard!

It’s ok to use boolean values as values, not just in if and while:

char c = 'a';
bool vowel;
if (c=='a' || c=='e' || c=='i' || c=='o' || c=='u')
    vowel=true;
else
    vowel=false;
cout << boolalpha << vowel << '\n';

true

 

char c = 'a';
bool vowel = (c=='a' || c=='e' || c=='i' || c=='o' || c=='u');
cout << boolalpha << vowel << '\n';

true

Return is easy

return is not a function, so parentheses are not required:

int main() {
    cout << "Hello\n";
    return 0;  // Note lack of parens
}

Hello

throw

• throw is not equivalent to “produce an error”.
• The compiler does not throw errors.
• Dividing by zero does not throw an error (though it could).
• Dereferencing a null pointer does not throw an error (though it could).
• On the other hand, this is defined to throw an error:

string s = "bonehead";
cout << s.at(12);

terminate called after throwing an instance of 'std::out_of_range'
  what():  basic_string::at: __n (which is 12) >= this->size() (which is 8)
SIGABRT: Aborted